@storybook/addon-actions version 5.0.0 marks a significant update from the previous stable version, 4.1.18, offering developers a refined action logging experience within their Storybook environments. One key difference is the removal of peer dependencies on React, which were present in version 4.1.18, streamlining installation and dependency management for users already working with specific React versions.
The update introduces several new dependencies, including polished, fast-deep-equal, and @storybook/theming, along with version bumps in core dependencies. These changes contribute to improved styling capabilities, more robust deep equality checks, and greater consistency with Storybook's overall theming system. Developers benefit from a more polished and visually cohesive interaction with action logs. The update also brings the addon's components and core events up to the 5.0.0 standard, ensuring better compatibility with other Storybook addons and core functionalities. Importantly, version 5.0.0 targets newer versions of React, requiring at least React 16.8.1. Conversely, version 4.1.18 uses older dependency versions but offers React peer dependency which can be beneficial for projects using older React versions. The unpacked size has decreased in 5.0.0 compared to 4.1.18, potentially indicating improved build optimization. Developers upgrading should carefully review these dependency changes to ensure compatibility within their projects.
All the vulnerabilities related to the version 5.0.0 of the package
node-fetch forwards secure headers to untrusted sites
node-fetch forwards secure headers such as authorization
, www-authenticate
, cookie
, & cookie2
when redirecting to a untrusted site.
Prototype Pollution in lodash
Versions of lodash prior to 4.17.19 are vulnerable to Prototype Pollution. The functions pick
, set
, setWith
, update
, updateWith
, and zipObjectDeep
allow a malicious user to modify the prototype of Object if the property identifiers are user-supplied. Being affected by this issue requires manipulating objects based on user-provided property values or arrays.
This vulnerability causes the addition or modification of an existing property that will exist on all objects and may lead to Denial of Service or Code Execution under specific circumstances.
Prototype Pollution in highlight.js
Affected versions of this package are vulnerable to Prototype Pollution. A malicious HTML code block can be crafted that will result in prototype pollution of the base object's prototype during highlighting. If you allow users to insert custom HTML code blocks into your page/app via parsing Markdown code blocks (or similar) and do not filter the language names the user can provide you may be vulnerable.
The pollution should just be harmless data but this can cause problems for applications not expecting these properties to exist and can result in strange behavior or application crashes, i.e. a potential DOS vector.
If your website or application does not render user provided data it should be unaffected.
Versions 9.18.2 and 10.1.2 and newer include fixes for this vulnerability. If you are using version 7 or 8 you are encouraged to upgrade to a newer release.
Manually patch your library to create null objects for both languages
and aliases
:
const HLJS = function(hljs) {
// ...
var languages = Object.create(null);
var aliases = Object.create(null);
Filter the language names that users are allowed to inject into your HTML to guarantee they are valid.
If you have any questions or comments about this advisory:
ReDOS vulnerabities: multiple grammars
The Regular expression Denial of Service (ReDoS) is a Denial of Service attack, that exploits the fact that most Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size). An attacker can then cause a program using a Regular Expression to enter these extreme situations and then hang for a very long time.
If are you are using Highlight.js to highlight user-provided data you are possibly vulnerable. On the client-side (in a browser or Electron environment) risks could include lengthy freezes or crashes... On the server-side infinite freezes could occur... effectively preventing users from accessing your app or service (ie, Denial of Service).
This is an issue with grammars shipped with the parser (and potentially 3rd party grammars also), not the parser itself. If you are using Highlight.js with any of the following grammars you are vulnerable. If you are using highlightAuto
to detect the language (and have any of these grammars registered) you are vulnerable. Exponential grammars (C, Perl, JavaScript) are auto-registered when using the common grammar subset/library require('highlight.js/lib/common')
as of 10.4.0 - see https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@10.4.0/build/highlight.js
All versions prior to 10.4.1 are vulnerable, including version 9.18.5.
Grammars with exponential backtracking issues:
And of course any aliases of those languages have the same issue. ie: hpp
is no safer than cpp
.
Grammars with polynomial backtracking issues:
And again: any aliases of those languages have the same issue. ie: ruby
and rb
share the same ruby issues.
If you have any questions or comments about this advisory: