Version 5.2.0 of @storybook/addon-actions brings notable changes for Storybook developers compared to the previous stable version, 5.1.11. A key update is the introduction of @storybook/client-api as a dependency, signalling enhanced integration with Storybook's core API and potentially unlocking new functionalities or improved workflows for interacting with actions within stories. The update also introduces a new dependency, specifically @storybook/components, this indicates a shift towards leveraging Storybook's component library for a more consistent and maintainable UI experience within the actions addon. This version also updates @storybook/theming and @storybook/core-events dependencies, ensuring seamless integration with the broader Storybook ecosystem and adherence to the latest styling and event handling conventions. The dependency lodash has been removed in favor of fast-deep-equal which improves speed and reliability. Although the functionality remains the same, these changes may affect your setup from a technical point of view and is a significant upgrade. From a development perspective, these modifications suggest an emphasis on improved component reusability, a more cohesive UI, and enhanced alignment with Storybook's evolving architecture, ultimately making the action logging process more integrated and efficient for users. The release date of 5.2.0 is September 14, 2019, a month after the release of version 5.1.11 on August 13, 2019.
All the vulnerabilities related to the version 5.2.0 of the package
Cross site scripting in markdown-to-jsx
Versions of the package markdown-to-jsx before 7.4.0 are vulnerable to Cross-site Scripting (XSS) via the src property due to improper input sanitization. An attacker can execute arbitrary code by injecting a malicious iframe element in the markdown.
Prototype Pollution in highlight.js
Affected versions of this package are vulnerable to Prototype Pollution. A malicious HTML code block can be crafted that will result in prototype pollution of the base object's prototype during highlighting. If you allow users to insert custom HTML code blocks into your page/app via parsing Markdown code blocks (or similar) and do not filter the language names the user can provide you may be vulnerable.
The pollution should just be harmless data but this can cause problems for applications not expecting these properties to exist and can result in strange behavior or application crashes, i.e. a potential DOS vector.
If your website or application does not render user provided data it should be unaffected.
Versions 9.18.2 and 10.1.2 and newer include fixes for this vulnerability. If you are using version 7 or 8 you are encouraged to upgrade to a newer release.
Manually patch your library to create null objects for both languages and aliases:
const HLJS = function(hljs) {
// ...
var languages = Object.create(null);
var aliases = Object.create(null);
Filter the language names that users are allowed to inject into your HTML to guarantee they are valid.
If you have any questions or comments about this advisory:
ReDOS vulnerabities: multiple grammars
The Regular expression Denial of Service (ReDoS) is a Denial of Service attack, that exploits the fact that most Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size). An attacker can then cause a program using a Regular Expression to enter these extreme situations and then hang for a very long time.
If are you are using Highlight.js to highlight user-provided data you are possibly vulnerable. On the client-side (in a browser or Electron environment) risks could include lengthy freezes or crashes... On the server-side infinite freezes could occur... effectively preventing users from accessing your app or service (ie, Denial of Service).
This is an issue with grammars shipped with the parser (and potentially 3rd party grammars also), not the parser itself. If you are using Highlight.js with any of the following grammars you are vulnerable. If you are using highlightAuto to detect the language (and have any of these grammars registered) you are vulnerable. Exponential grammars (C, Perl, JavaScript) are auto-registered when using the common grammar subset/library require('highlight.js/lib/common') as of 10.4.0 - see https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@10.4.0/build/highlight.js
All versions prior to 10.4.1 are vulnerable, including version 9.18.5.
Grammars with exponential backtracking issues:
And of course any aliases of those languages have the same issue. ie: hpp is no safer than cpp.
Grammars with polynomial backtracking issues:
And again: any aliases of those languages have the same issue. ie: ruby and rb share the same ruby issues.
If you have any questions or comments about this advisory: