The @storybook/addon-essentials package, crucial for enhancing the Storybook development experience, saw a recent update from version 7.2.2 to 7.2.3. Both versions, described as "Curated addons to bring out the best of Storybook," bundle a suite of helpful tools. Examining the dependencies, version 7.2.3 upgraded its internal dependencies to their corresponding 7.2.3 versions - including packages like @storybook/addon-docs, @storybook/core-common, @storybook/manager-api, and several other essential Storybook add-ons. This ensures internal consistency and may bring improvements and bug fixes inherited from those updated packages, without introducing breaking changes, given the minor version bump.
The development dependencies, including TypeScript and @storybook/vue, remained consistent across both versions, suggesting no changes in the core build or testing environments. The peer dependencies also remained the same, indicating maintained compatibility with various React versions. From a high-level perspective, developers can infer that version 7.2.3 delivers incremental refinements and bug fixes rather than a significant overhaul. For those already using @storybook/addon-essentials, upgrading to 7.2.3 is recommended to leverage the latest enhancements and maintain compatibility within the Storybook ecosystem. The MIT license and the hosted repository on GitHub ensure transparency and community contributions. The update released on August 11, 2023, two days after release of previous version 7.2.2, signals active development and ongoing support of the Storybook project and related packages.
All the vulnerabilities related to the version 7.2.3 of the package
esbuild enables any website to send any requests to the development server and read the response
esbuild allows any websites to send any request to the development server and read the response due to default CORS settings.
esbuild sets Access-Control-Allow-Origin: *
header to all requests, including the SSE connection, which allows any websites to send any request to the development server and read the response.
https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L121 https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L363
Attack scenario:
http://malicious.example.com
).fetch('http://127.0.0.1:8000/main.js')
request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.http://127.0.0.1:8000/main.js
.In this scenario, I assumed that the attacker knows the URL of the bundle output file name. But the attacker can also get that information by
/index.html
: normally you have a script tag here/assets
: it's common to have a assets
directory when you have JS files and CSS files in a different directory and the directory listing feature tells the attacker the list of files/esbuild
SSE endpoint: the SSE endpoint sends the URL path of the changed files when the file is changed (new EventSource('/esbuild').addEventListener('change', e => console.log(e.type, e.data))
)The scenario above fetches the compiled content, but if the victim has the source map option enabled, the attacker can also get the non-compiled content by fetching the source map file.
npm i
npm run watch
fetch('http://127.0.0.1:8000/app.js').then(r => r.text()).then(content => console.log(content))
in a different website's dev tools.Users using the serve feature may get the source code stolen by malicious websites.