Storybook React has released version 8.0.0, a significant update compared to the previous stable version 7.6.20. A key difference lies in the updated dependencies. Version 8.0.0 bumps several core Storybook packages like @storybook/types, @storybook/docs-tools, @storybook/preview-api, @storybook/client-logger, and @storybook/react-dom-shim to version 8.0.0, ensuring greater consistency and potentially leveraging new features within the Storybook ecosystem. The devDependencies have also experienced updates, notably no longer including @babel/core and jest-specific-snapshot, instead adding @types/semver and @types/babel-plugin-react-docgen and babel-plugin-react-docgen. These changes suggest a shift in the build and testing process.
A subtle but important change is in the peerDependencies. The typescript dependency has changed from * to >= 4.2.x. This shows that the new version enforces a minimum Typescript version improving type safety and API consistency with recent Typescript features.
For developers, upgrading to Storybook React 8.0.0 offers access to the latest improvements and bug fixes within the Storybook platform. It is crucial to examine your project's dependencies and adjust your Typescript version to fulfill the new peerDependencies criteria. The removal and addition of certain devDependencies reflect some changes on how the code is built and tested and it's relevant to investigate them.
All the vulnerabilities related to the version 8.0.0 of the package
esbuild enables any website to send any requests to the development server and read the response
esbuild allows any websites to send any request to the development server and read the response due to default CORS settings.
esbuild sets Access-Control-Allow-Origin: * header to all requests, including the SSE connection, which allows any websites to send any request to the development server and read the response.
https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L121 https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L363
Attack scenario:
http://malicious.example.com).fetch('http://127.0.0.1:8000/main.js') request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.http://127.0.0.1:8000/main.js.In this scenario, I assumed that the attacker knows the URL of the bundle output file name. But the attacker can also get that information by
/index.html: normally you have a script tag here/assets: it's common to have a assets directory when you have JS files and CSS files in a different directory and the directory listing feature tells the attacker the list of files/esbuild SSE endpoint: the SSE endpoint sends the URL path of the changed files when the file is changed (new EventSource('/esbuild').addEventListener('change', e => console.log(e.type, e.data)))The scenario above fetches the compiled content, but if the victim has the source map option enabled, the attacker can also get the non-compiled content by fetching the source map file.
npm inpm run watchfetch('http://127.0.0.1:8000/app.js').then(r => r.text()).then(content => console.log(content)) in a different website's dev tools.Users using the serve feature may get the source code stolen by malicious websites.