Rollup-plugin-esbuild-minify is a valuable tool for developers using Rollup to bundle their JavaScript code, offering a streamlined way to integrate esbuild's lightning-fast minification directly into their build process. Version 1.0.7 introduces notable updates compared to its predecessor, version 1.0.6, primarily centered around dependency upgrades. Most significantly, the esbuild dependency jumps from version ^0.14.51 to ^0.15.12. This upgrade brings with it the performance improvements and new features inherent in the newer esbuild release, potentially leading to faster minification times and enhanced code optimization for users.
Another change is in peerDependencies. In version 1.0.6 the plugin was compatible only with rollup version ^2, while version 1.0.7 expands its peer dependency to include Rollup version 3, specifying rollup: ^2 || ^3. This broadens the plugin's compatibility, allowing developers using Rollup 3 to seamlessly integrate the esbuild minification process.
If you are upgrading from version 1.0.6, ensure that you have updated your esbuild dependency and that your Rollup configuration is compatible with either Rollup v2 or v3 if upgrading to use version 1.0.7. While most other dependencies remain consistent between the two versions, the core changes to esbuild and Rollup compatibility are key considerations for developers seeking the best minification performance and wider framework support.
All the vulnerabilities related to the version 1.0.7 of the package
esbuild enables any website to send any requests to the development server and read the response
esbuild allows any websites to send any request to the development server and read the response due to default CORS settings.
esbuild sets Access-Control-Allow-Origin: * header to all requests, including the SSE connection, which allows any websites to send any request to the development server and read the response.
https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L121 https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L363
Attack scenario:
http://malicious.example.com).fetch('http://127.0.0.1:8000/main.js') request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.http://127.0.0.1:8000/main.js.In this scenario, I assumed that the attacker knows the URL of the bundle output file name. But the attacker can also get that information by
/index.html: normally you have a script tag here/assets: it's common to have a assets directory when you have JS files and CSS files in a different directory and the directory listing feature tells the attacker the list of files/esbuild SSE endpoint: the SSE endpoint sends the URL path of the changed files when the file is changed (new EventSource('/esbuild').addEventListener('change', e => console.log(e.type, e.data)))The scenario above fetches the compiled content, but if the victim has the source map option enabled, the attacker can also get the non-compiled content by fetching the source map file.
npm inpm run watchfetch('http://127.0.0.1:8000/app.js').then(r => r.text()).then(content => console.log(content)) in a different website's dev tools.Users using the serve feature may get the source code stolen by malicious websites.