Tsup version 1.2.0 introduces several updates compared to its predecessor, version 1.1.0. Both versions, designed to simplify bundling with Rollup and ESBuild, share the same core functionality. However, 1.2.0 incorporates notable changes in its dependencies and development dependencies. Specifically, the rollup dependency is updated to '^2.10.0' (from '^2.8.2'), and rollup-plugin-esbuild is bumped to '^1.4.1' (from '^1.3.1'). These updates likely bring performance improvements, bug fixes, and new features from those underlying libraries.
Furthermore, the 1.2.0 release includes a suite of new development dependencies. These consist of jest, execa, ts-jest, fs-extra, prettier, @types/jest, @types/fs-extra, and rollup-plugin-dts. This addition suggests a stronger emphasis on testing (jest, ts-jest, execa, @types/jest), file system utilities (fs-extra, @types/fs-extra) and code formatting (prettier). The inclusion of rollup-plugin-dts indicates enhanced support for generating TypeScript declaration files (.d.ts), a crucial aspect for libraries targeting TypeScript users. Also, the file count has remained the same on both versions of the package but upgraded the unpacked size from 322870 to 440540 which is more than 100MB of difference. Developers leveraging tsup should evaluate these updates to determine their impact on build processes and the overall developer experience, especially if relying on TypeScript declaration generation or seeking improved testing capabilities.
All the vulnerabilities related to the version 1.2.0 of the package
tsup DOM Clobbering vulnerability
A DOM Clobbering vulnerability in tsup v8.3.4 allows attackers to execute arbitrary code via a crafted script in the import.meta.url to document.currentScript in cjs_shims.js components
esbuild enables any website to send any requests to the development server and read the response
esbuild allows any websites to send any request to the development server and read the response due to default CORS settings.
esbuild sets Access-Control-Allow-Origin: *
header to all requests, including the SSE connection, which allows any websites to send any request to the development server and read the response.
https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L121 https://github.com/evanw/esbuild/blob/df815ac27b84f8b34374c9182a93c94718f8a630/pkg/api/serve_other.go#L363
Attack scenario:
http://malicious.example.com
).fetch('http://127.0.0.1:8000/main.js')
request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.http://127.0.0.1:8000/main.js
.In this scenario, I assumed that the attacker knows the URL of the bundle output file name. But the attacker can also get that information by
/index.html
: normally you have a script tag here/assets
: it's common to have a assets
directory when you have JS files and CSS files in a different directory and the directory listing feature tells the attacker the list of files/esbuild
SSE endpoint: the SSE endpoint sends the URL path of the changed files when the file is changed (new EventSource('/esbuild').addEventListener('change', e => console.log(e.type, e.data))
)The scenario above fetches the compiled content, but if the victim has the source map option enabled, the attacker can also get the non-compiled content by fetching the source map file.
npm i
npm run watch
fetch('http://127.0.0.1:8000/app.js').then(r => r.text()).then(content => console.log(content))
in a different website's dev tools.Users using the serve feature may get the source code stolen by malicious websites.